Skip to content

Python 3.x support #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Python 3.x support #75

wants to merge 4 commits into from

Conversation

romanbsd
Copy link

I updated the QSTK for Python 3.x support. I'm using it for the coursera course. So far I hadn't had any problems.

@romanbsd
Copy link
Author

Is it going to be merged?

@pmiddend
Copy link

pmiddend commented Jun 2, 2018

Note that the tests don\t seem to run:

 tradesim() missing 3 required positional arguments: 'alloc', 'df_historic', and 'f_start_cash'

Though I'm not sure this is your fault or if the original repo's tests don't run, either.

@romanbsd
Copy link
Author

romanbsd commented Jun 6, 2018

@pmiddend I'll check. How do you run the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@avishniakov avishniakov avishniakov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanbsd @pmiddend @avishniakov